test: add runtime objects per step in e2e #782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmerr
changed the title
timraymond
reviewed
Oct 1, 2024
|
|
||
| var ErrEmptyRuntimeObject = errors.New("empty value for runtime object key") | ||
|
|
||
| type RuntimeObjects struct { |
There was a problem hiding this comment.
Would it make more sense to use context.Context? context.WithValue is the traditional untyped bag of stuff to hand to functions.
There was a problem hiding this comment.
True, worth investigation and I'll switch this pr to draft. I'm not entirely sure how I feel yet about passing untyped structs, but I'm starting to think we do need a way of passing scenario scoped resources, and I've seen the usage be abused very quickly. Shelving this for a later time
|
This PR will be closed in 7 days due to inactivity. |
github-actions
bot
added
the
meta/waiting-for-author
|
Pull request closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Satisfy the need to pass structs between steps. Would like runtime object keys to be more hardcoded, but for the moment this should suffice
Please provide a brief description of the changes made in this pull request.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.